cucumber / cucumber-js

Cucumber for JavaScript
https://cucumber.io
MIT License
5.04k stars 1.09k forks source link

support attachments with filenames #2297

Closed davidjgoss closed 1 year ago

davidjgoss commented 1 year ago

🤔 What's changed?

Add support for providing an optional filename for attachments, which is emitted as part of the attachment message and thus can be used in formatters.

To achieve this, we make the second argument to this.attach an options object, with backwards compatibility so a media type string still works as before.

⚡️ What's your motivation?

Follow the cross-platform standards.

🏷️ What kind of change is this?

📋 Checklist:


This text was originally generated from a template, then edited by hand. You can modify the template here.

coveralls commented 1 year ago

Coverage Status

coverage: 98.505% (+0.006%) from 98.499% when pulling b1804d4f3f8786265bd79ee42c6ee65d675f58ad on feat/attachment-filenames into 0518bb3323f3f8ae2b56e97375f01b8d9db111ad on main.