Fix type import from cucumber-expressions

florianmutter commented 11 months ago

🤔 What's changed?

The ParameterType type is properly exported by the cucumber-expressions module so no need to directly reference the file.

⚡️ What's your motivation?

Without this change tsc fails for me with the following error:

node_modules/@cucumber/cucumber/lib/support_code_library_builder/sourced_parameter_type_registry.d.ts:2:27 - error TS2307: Cannot find module '@cucumber/cucumber-expressions/dist/cjs/src/ParameterType' or its corresponding type declarations.

2 import ParameterType from '@cucumber/cucumber-expressions/dist/cjs/src/ParameterType';
                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Found 1 error in node_modules/@cucumber/cucumber/lib/support_code_library_builder/sourced_parameter_type_registry.d.ts:2

🏷️ What kind of change is this?

:bug: Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct
[ ] I've changed the behaviour of the code
- [ ] I have added/updated tests to cover my changes.
[ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
[ ] Users should know about my change
- [ ] I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

coveralls commented 11 months ago

coverage: 98.505%. remained the same when pulling 1152b61241f992d081db11b9e7d74cbd31d657f4 on florianmutter:florianmutter-patch-1 into fcbeb440ee03203357d5effab48181ffd275bc31 on cucumber:main.

aslakhellesoy commented 11 months ago

Hi @florianmutter,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber

davidjgoss commented 11 months ago

Released in https://github.com/cucumber/cucumber-js/releases/tag/v9.4.0

cucumber / cucumber-js