fix format option splitter problems

cucumber / cucumber-js

Cucumber for JavaScript

https://cucumber.io

MIT License

5.02k stars 1.09k forks source link

fix format option splitter problems #2315

Closed yusuke-noda closed 10 months ago

yusuke-noda commented 11 months ago

Referring to #2178

🤔 What's changed?

Reimplement OptionSplitter and fix the issue discussed in #2178 .

⚡️ What's your motivation?

Fixes #2178

🏷️ What kind of change is this?

:bug: Bug fix (non-breaking change which fixes a defect)
:zap: New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct
[x] I've changed the behaviour of the code
- [x] I have added/updated tests to cover my changes.
[ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
[ ] Users should know about my change
- [ ] I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

coveralls commented 11 months ago

coverage: 98.465% (+0.007%) from 98.458% when pulling 49fc84defa62097b209847c108f63c27505de37b on yusuke-noda:fix-2178-format-option-splitter into 89ec3b6e86540c12e53267633e5876a67ae854bc on cucumber:main.

davidjgoss commented 11 months ago

Thanks for doing this @yusuke-noda!

Relatedly, I released a change with 9.5.1 so that in a config file you can provide a two-item array directly instead of a single string to avoid the ambiguity of the splitting. But of course we'll still always need the splitting logic for the CLI.

I'll fully review and merge this shortly. Before releasing I might also add some deprecation warnings, because what I'd like to do long term is enforce quoting either side of the string if it contains colons, so we don't have to do such clever splitting with awareness of all the platform quirks.

aslakhellesoy commented 10 months ago

Hi @yusuke-noda,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber

davidjgoss commented 10 months ago

Released in https://github.com/cucumber/cucumber-js/releases/tag/v9.6.0