consistent pattern for imports - Githubissues

cucumber / cucumber-js

Cucumber for JavaScript

https://cucumber.io

MIT License

5.02k stars 1.09k forks source link

consistent pattern for imports #2336

Closed davidjgoss closed 10 months ago

davidjgoss commented 10 months ago

🤔 What's changed?

For Node.js standard library, using the node: protocol on imports for clarity
Sort imports in a consistent order (external first etc)

Both enforced and autofixed with ESLint.

⚡️ What's your motivation?

Consistent clarity for imports without manual intervention from contributors.

🏷️ What kind of change is this?

:bank: Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct
[ ] I've changed the behaviour of the code
- [ ] I have added/updated tests to cover my changes.
[ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
[ ] Users should know about my change
- [ ] I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

coveralls commented 10 months ago

coverage: 97.873% (+0.001%) from 97.872% when pulling 3ec48c8832ceaf82d6e1d015abe29f758aee407b on feat/node-imports into 3d23eec9938887ab5051744315a83ccf2781b15f on main.