cucumber / cucumber-js

Cucumber for JavaScript
https://cucumber.io
MIT License
5.04k stars 1.09k forks source link

Recent tmp update breaks cucumber-js on Node14 #2380

Closed KyleProdigy closed 6 months ago

KyleProdigy commented 7 months ago

πŸ‘“ What did you see?

Yesterday (Feb 27, 2024), The node package tmp released version 0.2.2. The version of cucumber-js my organization is using (v9.4.0) has the tmp dependency on version ^0.2.1, which causes it to make use of this latest tmp version.

This has caused all our automated e2e tests to break as there is a new error coming from this tmp update Screenshot 2024-02-28 at 1 53 20β€―PM

We are on Node version 14.5.0. Based on some research, this error may be related to the Node version.

βœ… What did you expect to see?

Our automated e2e tests to continue functioning, since we didn't change anything in our package dependency tree. Pinning the tmp dependency to "0.2.1" instead of "^0.2.1" would fix this issue, and prevent further surprise updates.

πŸ“¦ Which tool/library version are you using?

@cucumber/cucumber, version 9.4.0

πŸ”¬ How could we reproduce it?

Steps to reproduce the behavior:

  1. Install '@cucumber/cucumber' version '9.4.0'
  2. Run an automated test with this version and observe the error.
  3. I know these aren't detailed steps, but the fix here is just clamping the version # of tmp

πŸ“š Any additional context?

Related links:


This text was originally generated from a template, then edited by hand. You can modify the template here.

davidjgoss commented 6 months ago

Thanks for reporting @KyleProdigy. I'll pin the version on our side. But also, this should not really be breaking your CI assuming you have a lockfile?

KyleProdigy commented 6 months ago

Thanks for getting back to me @davidjgoss. The package with the breaking change has actually been resolved as of last week (tmp released version 0.2.3, which removed their rimraf dependency). So this is actually no longer an issue, apologies for not updating this thread.

While we did have a lockfile, it needed to be regenerated for other reasons, which caused the unpinned tmp version to get updated in the lockfile as well.

KyleProdigy commented 6 months ago

@davidjgoss Not sure if you still want to go ahead with the version pin, but I think this issue can be closed.

davidjgoss commented 6 months ago

Thanks for the update @KyleProdigy!