cucumber / cucumber-js

Cucumber for JavaScript
https://cucumber.io
MIT License
5.01k stars 1.09k forks source link

fix: use explicit status field to determine (not) running status #2386

Closed davidjgoss closed 3 months ago

davidjgoss commented 3 months ago

πŸ€” What's changed?

Update the logic in SupportCodeLibraryBuilder so instead of using a heuristic (absence of cwd) to detect if we are trying to register support code against a non-running install, we have a specific status field that we update along the create/reset/finalize lifecycle.

⚑️ What's your motivation?

In #2353 we are seeing several Windows users reporting this error since 10.0.0 with a configuration that works fine in 9.x.x. This suggests the invalid install error might be a false positive and masking a different issue.

🏷️ What kind of change is this?

πŸ“‹ Checklist:


This text was originally generated from a template, then edited by hand. You can modify the template here.

coveralls commented 3 months ago

Coverage Status

coverage: 98.387% (+0.002%) from 98.385% when pulling 66c9bbde29c9d2a34d5d2fe8c4dcde1062a2f0f5 on fix/support-code-library-status into 5a4f129fdb7020e1bc9c1a539a3cea93307881b8 on main.