chore: some fields can be readonly - Githubissues

cucumber / cucumber-js

Cucumber for JavaScript

https://cucumber.io

MIT License

5.01k stars 1.09k forks source link

chore: some fields can be readonly #2394

Closed asashour closed 2 months ago

asashour commented 3 months ago

🤔 What's changed?

There are three potential enhancements in this PR

Some fields can be readonly
Remove redundant await Promise.resolve
Remove redundant await Promise.reject

⚡️ What's your motivation?

🏷️ What kind of change is this?

:bank: Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct
[ ] I've changed the behaviour of the code
- [ ] I have added/updated tests to cover my changes.
[ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
[ ] Users should know about my change
- [ ] I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

coveralls commented 3 months ago

coverage: 98.392%. remained the same when pulling 33ad8eae600825d351baed5e51c64d7c21780e50 on asashour:enhancements into 9dde5d02f25786b4dc4ea78ca86819bbe409b321 on cucumber:main.