search

cucumber / cucumber-js

Cucumber for JavaScript
https://cucumber.io
MIT License
5.07k stars 1.09k forks source link

deprecation error with parseGherkinMessageStream and PickleFilter #2426

Closed ymouhat closed 2 months ago

ymouhat commented 2 months ago

👓 What did you see?

Following error are returned when executing cucumber test

[0-0] Cucumber report JSON files will be written to /xtrem/test/services/adapters/xtrem-intacct/test-report/cucumber [0-0] Allure results files will be written to test-report/allure-results/ [0-0] JUnit XML files will be written to /xtrem/test/services/adapters/xtrem-intacct/test-report/junit [0-0] (node:27) DeprecationWarning: PickleFilter is deprecated, use loadSources instead; see https://github.com/cucumber/cucumber-js/blob/main/docs/deprecations.md [0-0] (Use node --trace-deprecation ... to show where the warning was created) [0-0] (node:27) DeprecationWarning: parseGherkinMessageStream is deprecated, use loadSources instead; see https://github.com/cucumber/cucumber-js/blob/main/docs/deprecations.md [0-0] RUNNING in chrome - file:///test/cucumber/smoke-test-data.feature [0-0] FAILED in chrome - file:///test/cucumber/smoke-test-data.feature

This is weird a deprecation has been done for cucumber 11 and we are currently using cucumber 10.7.0

Could you please advise?

✅ What did you expect to see?

No error returned.

📦 Which tool/library version are you using?

Node v20.17.0 "@cucumber/cucumber": "^10.7.0", "webdriverio": "8.12.1",

🔬 How could we reproduce it?

Issue not reproduced locally via a normal ibuild ( pnpm run build) but happening with Azure devops pipeline executing test via a docker image containing a glocal install of cucumber framework.

📚 Any additional context?

No response

davidjgoss commented 2 months ago

deprecation has been done for cucumber 11 and we are currently using cucumber 10.7.0

It sounds as though you might be confusing deprecation with removal. These things were deprecated in 8.0.0 and 8.7.0, and the deprecation warning was added then. This is what you see now - a warning which doesn't affect your tests. Removal was finally done in 11.0.0.

davidjgoss commented 2 months ago

(Also, from 8.16.0 it looks like webdriverio stopped using these deprecated objects, so upgrading to that or higher should make those warnings disappear.)

ymouhat commented 2 months ago

Hi @davidjgoss Thank you for your feedback We are planning to upgrade wdio to latest version 8. I let you know Have a nice day