cucumber / cucumber-jvm-groovy

Cucumber Groovy
MIT License
23 stars 10 forks source link

Update to latest groovy and cucumber jvm #47

Closed lsiu closed 1 year ago

lsiu commented 1 year ago

🤔 What's changed?

Upgrade to the latest groovy version 4.0.11 and cucumber-core version 7.11.2

⚡️ What's your motivation?

I would like to use cucumber-groovy-jvm with the latest cucumber-core

🏷️ What kind of change is this?

♻️ Anything particular you want feedback on?

📋 Checklist:

lsiu commented 1 year ago

I put the groovy-cli-test back it. It just wraps the cli mechanism provided by cucumber-core. Doesn't look like too much work to support it for now.

aslakhellesoy commented 1 year ago

Hi @lsiu,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber

mpkorstanje commented 1 year ago

Cheers!

@lsiu since you are one of the few people using cucumber-jvm-groovy, would you be interested in maintaining it?

lsiu commented 1 year ago

@mpkorstanje , I will do what I can. To be honest, I started with cucumber-jvm-groovy in my previous job. Finally, got around to introduce this in my new job, but found out cucumber-jvm-groovy is no longer maintained. Tried cucumber-jvm-java8 and learned it is getting deprecated, so I went with cucumber-jvm-java. IMHO, the duplicate step text in annotation and method name is still not idea, so I am trying to give cucumber-jvm-groovy a kick.

mpkorstanje commented 1 year ago

Mmh. Cucumber-Java 8 hasn't been deprecated yet. And I'm planning to have a replacement ready when that happens.

If you want you could help out with the replacement instead. But I'll leave that up to your interests:

https://github.com/cucumber/cucumber-jvm/pull/2542