Allow Configuring Flush on Every Write

jGleitz commented 2 years ago

🤔 What's the problem you're trying to solve?

Currently, the lazy output of PrettyFormatter means for us that

IntelliJ does not correctly correlate test cases with their output.
Lines that are logged during test execution do not properly interleave with printed test cases.
Maven output can be messed up, especially on Jenkins

✨ What's your proposed solution?

I see that the lazy flushing (i.e. setting flushEveryWrite of NiceAppendable to false) was added consciously after #2481. So I guess removing it is not an option. Has it been explored whether flushing after every event would still work out performance-wise?

In my experiment, setting flushEveryWrite to true had no perceivable impact on test performance. Hence, if there is no solution that fits everybody, I think the best solution would be to offer a way to configure flushEveryWrite.

⛏ Have you considered any alternatives or workarounds?

see above

📚 Any additional context?

This text was originally generated from a template, then edited by hand. You can modify the template here.

mpkorstanje commented 2 years ago

Have you tried after https://github.com/cucumber/cucumber-jvm/pull/2573? Should be in 7.4.

jGleitz commented 2 years ago

Oh, sorry, I didn’t realize that we weren’t on the latest release. 7.4 fixes the issue.

cucumber / cucumber-jvm