search

cucumber / cucumber-jvm

Cucumber for the JVM
https://cucumber.io
MIT License
2.7k stars 2.02k forks source link

Support diff view for failed assertEqual condition in Intelij IDEA #2607

Closed avokin2 closed 1 year ago

avokin2 commented 2 years ago

I see that cucumber-core team has implemented output formatter for IntelliJ IDEA. Thank you. Now JetBrains doesn't need to ship output formatter for every Cucumber-Java version.

🤔 What's the problem you're trying to solve?

Unfortunatelly built-in formatter (TeamCityPlugin) doesn't provide "expected" and "actual" attributes in cause of failed condition. That's why diff toolwindow is unavailable for cucumber tests.

✨ What's your proposed solution?

It's necessary to add the "expected" and the "actual" attributes to the ##teamcity[testFailed message.

⛏ Have you considered any alternatives or workarounds?

We could ship a new version of output formatter for Cucumber-Java v.7. But I believe it's much better when the TeamCityPlugin built in cucumber-core.

📚 Any additional context?

Issue in IDEA tracker: IDEA-125830

This text was originally generated from a template, then edited by hand. You can modify the template here.

mpkorstanje commented 2 years ago

I'm happy to see that this has your attention! Could you please pick up IDEA-276468 so I can get rid of the workarounds for IDEA:

https://github.com/cucumber/cucumber-jvm/blob/ee6b693184b463c023a265fe98fa9ab5ab2ce819/cucumber-core/src/main/java/io/cucumber/core/options/PluginOption.java#L62-L72