Closed mpkorstanje closed 9 months ago
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
3ae7af5
) 84.95% compared to head (bea8cca
) 84.97%.
Files | Patch % | Lines |
---|---|---|
...ucumber/core/resource/JarUriFileSystemService.java | 85.71% | 0 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🤔 What's changed?
Spring Boot 3.2 changed the URL format of their nested jars[1] to be more compliant with JDK expectations. They now represented nested jars as their own
nested
scheme rather than thefile
scheme. This allows these URLs to be used seamlessly withFileSystems.newFileSystem
.Unfortunately the workarounds for Spring Boot 3.1 did not account for this.
Additionally, our jar uri parsing assumed naively that there would only be a single
!/
in a regular jar uri. However, jar uris are recursively defined as[2]:And while this should allow Cucumber to discover resources in nested jars as well it does seem that Spring Boot 3.2 still has some issues[3].
Closes: #2828
🏷️ What kind of change is this?
📋 Checklist: