Open mpkorstanje opened 9 months ago
Attention: Patch coverage is 91.81034%
with 19 lines
in your changes missing coverage. Please review.
Project coverage is 84.86%. Comparing base (
6549826
) to head (b6ab3cb
). Report is 33 commits behind head on main.:exclamation: Current head b6ab3cb differs from pull request most recent head 294d880
Please upload reports for the commit 294d880 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The current implementation of the JUnit Platform Engine treats @SelectClasspathResource
aimed at directories as if all resources in that directory should be considered. This is not the intended usage, for this @SelectPackages
should be used.
Cucumbers documentation consistently uses @SelectClasspathResource
.
This will become a problem if/when we start to use the EngineDiscoveryRequestResolver
with (#2835, https://github.com/junit-team/junit5/pull/3705, https://github.com/junit-team/junit5/pull/3718) because @SelectClasspathResource
will cause an exception to be thrown when used with a non-existing resource.
🤔 What's changed?
⚡️ What's your motivation?
Fully utilize the
EngineDiscoveryRequestResolver
API to reduce our own complexity (https://github.com/junit-team/junit5/pull/3705, https://github.com/junit-team/junit5/pull/3718)🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist: