cucumber / cucumber-jvm

Cucumber for the JVM
https://cucumber.io
MIT License
2.69k stars 2.02k forks source link

Improved support for multiple classloaders in IncrementingUuidGenerator #2853

Closed jkronegg closed 4 months ago

jkronegg commented 4 months ago

🤔 What's changed?

Corrected a test-case which fails rarely but sometimes. Added possibility to give a specific classloader identifier.

⚡️ What's your motivation?

Fixes #2851

🏷️ What kind of change is this?

♻️ Anything particular you want feedback on?

The comments in #2851 describe the problem and solution.

📋 Checklist:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.99%. Comparing base (c6c0ada) to head (d1261a9). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2853 +/- ## ========================================= Coverage 84.99% 84.99% - Complexity 2733 2734 +1 ========================================= Files 331 331 Lines 9557 9559 +2 Branches 918 918 ========================================= + Hits 8123 8125 +2 Misses 1109 1109 Partials 325 325 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mpkorstanje commented 4 months ago

Cheers!