search

cucumber / cucumber-jvm

Cucumber for the JVM
https://cucumber.io
MIT License
2.69k stars 2.02k forks source link

[JUnit Platform Engine] @SelectPackages not @SelectClasspathResource #2858

Closed mpkorstanje closed 4 months ago

mpkorstanje commented 4 months ago

🤔 What's changed?

@SelectClasspathResource is intended to be used for single resources whereas @SelectPackages is intended for packages containing those resources.

Currently, it doesn't matter because Cucumber is smart enough to scan everything given a directory. But we may want to change that in the future when we use JUnits EngineDiscoveryRequestResolver API (https://github.com/cucumber/cucumber-jvm/pull/2835).

🏷️ What kind of change is this?

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.99%. Comparing base (537dccb) to head (6e7f72c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2858 +/- ## ========================================= Coverage 84.99% 84.99% Complexity 2734 2734 ========================================= Files 331 331 Lines 9559 9559 Branches 918 918 ========================================= Hits 8125 8125 Misses 1109 1109 Partials 325 325 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.