cucumber / cucumber-jvm

Cucumber for the JVM
https://cucumber.io
MIT License
2.69k stars 2.02k forks source link

[JUnit Platform Engine] Support naming examples #2860

Closed maestro-game closed 3 months ago

maestro-game commented 3 months ago

Hi, this closes #2743. changes:

Comments and advice are welcome!

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.81%. Comparing base (cf80f51) to head (8072ab7). Report is 1 commits behind head on main.

Files Patch % Lines
...platform/engine/DefaultNamingStrategyProvider.java 94.44% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2860 +/- ## ============================================ + Coverage 84.80% 84.81% +0.01% - Complexity 2716 2728 +12 ============================================ Files 331 331 Lines 9404 9426 +22 Branches 902 902 ============================================ + Hits 7975 7995 +20 - Misses 1108 1109 +1 - Partials 321 322 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mpkorstanje commented 3 months ago

Cheers! I'll try and have a look at this tomorrow.

maestro-game commented 3 months ago

Hi and thanks for comments! Really helped me come up with a better solution. Are there any possible improvements for current version?

maestro-game commented 3 months ago

Hi again. I think I got your idea! Tried to implement it. Also fixed the code formatting. Still open for advices)

aslakhellesoy commented 3 months ago

Hi @maestro-game,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber