Closed maestro-game closed 3 months ago
Attention: Patch coverage is 95.00000%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 84.81%. Comparing base (
cf80f51
) to head (8072ab7
). Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
...platform/engine/DefaultNamingStrategyProvider.java | 94.44% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Cheers! I'll try and have a look at this tomorrow.
Hi and thanks for comments! Really helped me come up with a better solution. Are there any possible improvements for current version?
Hi again. I think I got your idea! Tried to implement it. Also fixed the code formatting. Still open for advices)
Hi @maestro-game,
Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾
In return for this generous offer we hope you will:
On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber
Hi, this closes #2743. changes:
cucumber.junit-platform.naming-strategy.short.example-name
for example naming in case of short naming strategycucumber.junit-platform.naming-strategy.long.example-name
for example naming in case of long naming strategyComments and advice are welcome!