cucumber / cucumber-jvm

Cucumber for the JVM
https://cucumber.io
MIT License
2.69k stars 2.02k forks source link

[Core] Include stack traces in html report #2862

Closed mpkorstanje closed 3 months ago

mpkorstanje commented 3 months ago

🤔 What's changed?

Before

image

After

image

Depends on https://github.com/cucumber/messages/pull/213 Depends on https://github.com/cucumber/cucumber-junit-xml-formatter/pull/30

⚡️ What's your motivation?

With https://github.com/cucumber/react-components/pull/345 the html formatter started to support rendering stack traces. Unfortunately this also broke the regular rendering of stacktrace. And fixing this required including the stack trace the xml report aswell so that when the Convertor in messages was fixed to always include the stacktrace, we wouldn't render the stacktrace in the xml formatter twice.

🏷️ What kind of change is this?

📋 Checklist:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.99%. Comparing base (9eb958d) to head (37a7596).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2862 +/- ## ============================================ - Coverage 84.99% 84.99% -0.01% + Complexity 2734 2733 -1 ============================================ Files 331 331 Lines 9559 9555 -4 Branches 918 918 ============================================ - Hits 8125 8121 -4 Misses 1109 1109 Partials 325 325 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.