search

cucumber / cucumber-jvm

Cucumber for the JVM
https://cucumber.io
MIT License
2.7k stars 2.02k forks source link

Lazy loading feature file and running (JUnit or TestNG Runner) #989

Closed stanislav-antufeev closed 8 years ago

stanislav-antufeev commented 8 years ago

I am facing the problem with running huge number of feature files, around 10,000. Some of them contains multiple scenarios (more than 5)and i am getting OutOfMemory error on ~1200 executed feature files. As I understand how JUnit and TestNG runner classes have been implemented, they are both loading all given feature file into memory and parsing using Gerkhin library. Current implementation of JUnit and TestNG feature runners has such limitation. I found that TestNG framework has a special type of DataProvider which returns Iterator. I prepared some implementation of additional TestNG Runner class with lazy loading and running feature one by one.

stanislav-antufeev commented 8 years ago

Could you please verify my commit. I can understand that it is not common case but an issue is exist and should be fixed or as I created a separate solution to run huge amount of feature files.

aslakhellesoy commented 8 years ago

Please create a pull request. Our CI will then verify it automatically.

stanislav-antufeev commented 8 years ago

I am already created and closed. I was confused by GIT Hub process of pull request a bit. @aslakhellesoy Are you seeing my pull request ?

aslakhellesoy commented 8 years ago

Yes, I can see #991 thanks

stanislav-antufeev commented 8 years ago

Closing issue because feature is implemented not completely.

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.