Switch to prepend instead of alias chaining methods

wagenet commented 4 years ago

Fixes #454

wagenet commented 4 years ago

Looks like the test failures are unrelated.

wagenet commented 4 years ago

@luke-hill I can definitely change it. What sort of naming would you prefer?

luke-hill commented 4 years ago

your namespacing has an Extensions module. So either add a new folder for that or remove that module.

wagenet commented 4 years ago

@luke-hill what about the other stuff in lib/cucumber/rails/action_controller.rb? Previously, it had things from two different modules.

luke-hill commented 4 years ago

Things aren't great here. So if you want to fix up more stuff, go nuts. I'm just here to make sure we make stuff better ideally with each PR.

luke-hill commented 4 years ago

ping @wagenet

wagenet commented 4 years ago

@luke-hill sorry for the delay. I think it is ready now. Let me know if you need anything else.

wagenet commented 4 years ago

@luke-hill I don't think the CI failures are my fault, but please let me know if I'm mistaken.

wagenet commented 4 years ago

@luke-hill I'm seeing lots of stuff around deprecations in the failures.

luke-hill commented 4 years ago

The failures aren't anything to worry about if they're rails6. They changed something between 6.0.1 and 6.0.2 that we've yet to hear back / diagnose

wagenet commented 4 years ago

@luke-hill ok, looks like we're probably ok now.

aslakhellesoy commented 4 years ago

Hi @wagenet,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber

cucumber / cucumber-rails

Switch to prepend instead of alias chaining methods #457