search

cucumber / cucumber-rails

Rails Generators for Cucumber with special support for Capybara and DatabaseCleaner
https://github.com/cucumber/cucumber-rails
MIT License
1.02k stars 327 forks source link

Drop `git` from gemspec #475

Closed utkarsh2102 closed 4 years ago

utkarsh2102 commented 4 years ago

Hi,

Thanks for working on this! :heart: However, while maintaining this in Debian, we found that this library relies on git to list the files (which could be done via pure Ruby alternative):

https://github.com/cucumber/cucumber-rails/blob/9b8f155174f1c7e6150f57cfa75422f06fe42e2b/cucumber-rails.gemspec#L48-L49

I'd be happy to raise a PR if you concur in dropping git from gemspec :smile: Let me know what you think!?

luke-hill commented 4 years ago

Go for it, if you have the time. It's not something really high priority, but I'd review and merge.

utkarsh2102 commented 4 years ago

Thanks, Luke, opened as #476 :rocket: