Drop `git ls-files` in gemspec

[utkarsh2102]

Hi,

Thanks again for working on this! :heart: However, while maintaining this in Debian, we found that this library relies on git to list the files which could be done via pure Ruby alternative -- which is what this PR does.

Also, added rubocop-packaging as a development_dependency which will ensure the best practices. Here's what it shows:

Inspecting 33 files
...C.............................

Offenses:

cucumber-rails.gemspec:49:24: C: Packaging/GemspecGit: Avoid using git to produce lists of files.
Downstreams often need to build your package in an environment that does not have git (on purpose).
Use some pure Ruby alternative, like Dir or Dir.glob.
  s.files            = `git ls-files`.split("\n")
                       ^^^^^^^^^^^^^^

cucumber-rails.gemspec:50:24: C: Packaging/GemspecGit: Avoid using git to produce lists of files.
Downstreams often need to build your package in an environment that does not have git (on purpose).
Use some pure Ruby alternative, like Dir or Dir.glob.
  s.test_files       = `git ls-files -- {spec,features}/*`.split("\n")
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

33 files inspected, 2 offense detected

And this PR fixes the same, which helps us in shipping this in Debian! :tada: Hope this would make sense and you'll be open to this change :100:

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>

---

CC: @luke-hill :smile: Closes: #475

[aslakhellesoy]

Hi @utkarsh2102,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
• 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber

[utkarsh2102]

Wow, thank you, @luke-hill and @aslakhellesoy :heart: