After some deep digging, we do not test for this anywhere in our codebase
Details
Add some extra tests covering a whole heap of scenarios we never covered before
Refactor the Strategy code to be a little more granular, removing the large mega-class and having some better definitions of our defaults
Motivation and Context
This helps triage a couple of config issues that were reported and could have been bugs
How Has This Been Tested?
Huge amount of new stuff has been added
Screenshots (if appropriate):
Types of changes
Adding new tests, refactoring code
Checklist:
[x] I've added tests for my code.
[ ] My change requires a change to the documentation.
Summary
After some deep digging, we do not test for this anywhere in our codebase
Details
Add some extra tests covering a whole heap of scenarios we never covered before Refactor the Strategy code to be a little more granular, removing the large mega-class and having some better definitions of our defaults
Motivation and Context
This helps triage a couple of config issues that were reported and could have been bugs
How Has This Been Tested?
Huge amount of new stuff has been added
Screenshots (if appropriate):
Types of changes
Adding new tests, refactoring code
Checklist: