cucumber / cucumber-rails

Rails Generators for Cucumber with special support for Capybara and DatabaseCleaner
https://github.com/cucumber/cucumber-rails
MIT License
1.02k stars 327 forks source link

`cucumber-rails` incompatible with latest `cucumber-ruby` #538

Closed kmarcisz closed 2 years ago

kmarcisz commented 2 years ago

πŸ‘“ What did you see?

When updating to latest cucumber-ruby I couldn't jump to version 8 without dropping to much older version of cucumber-rails.

root@00fe90130848:/usr/src/app# bundle update --conservative cucumber cucumber-rails
(...)
Fetching cucumber 8.0.0 (was 7.1.0)
Installing cucumber 8.0.0 (was 7.1.0)
(...)
Fetching cucumber-rails 1.4.0 (was 2.5.1)
Installing cucumber-rails 1.4.0 (was 2.5.1)
(...)
Note: cucumber-rails version regressed from 2.5.1 to 1.

βœ… What did you expect to see?

I expected to see both cucumber-ruby and cucumber-rails be updated to newest published versions.

πŸ“¦ Which tool/library version are you using?

Rails 7.0.3 Ruby 2.7.6

πŸ”¬ How could we reproduce it?

Steps to reproduce the behavior:

  1. Set up a new Rails project
  2. Add gem cucumber to Gemfile
  3. Run command bundle install
  4. See version 1.x of cucumber-rails installed and not version 2.x
luke-hill commented 2 years ago

Because we don't permit it yet.

aslakhellesoy commented 2 years ago

So let’s keep this open as a reminder to make cucumber-rails compatible with cucumber-ruby 8.

mattwynne commented 2 years ago

Thanks for the feedback @kmarcisz!

Would you like to help us fix it? I guess we just need a new release of cucumber-rails with the dependency updated.

If you'd like to book some time to pair on it, you can access my calendar here.

mattwynne commented 2 years ago

Here we go: #541. Needs a release now.

mattwynne commented 2 years ago

I would like to set up #546 as part of delivering this.

svenwin commented 2 years ago

Just checked out cucumber-rails@main in one of our projects and bumped Cucumber to v8. It's working smoothly out of the box! I just need a release version now 🀣

luke-hill commented 2 years ago

Cheers. I'll get on it soon. We've just been fixing up a bunch of stuff with the pipelines e.t.c. so there will be quite a lot of non-package related fixes.

kevindew commented 2 years ago

@luke-hill is there any chance this will be released soon?

luke-hill commented 2 years ago

Sorry I have been swamped in other stuff and been a bit fluey. I'll get on this soon.

kevindew commented 2 years ago

No worries, hope you’re feeling better now