cucumber / cucumber-rails

Rails Generators for Cucumber with special support for Capybara and DatabaseCleaner
https://github.com/cucumber/cucumber-rails
MIT License
1.02k stars 327 forks source link

Add Rails 7.2 to test matrix #586

Closed p8 closed 1 month ago

p8 commented 1 month ago

🏷️ What kind of change is this?

📋 Checklist:

olleolleolle commented 1 month ago

@p8 Awesome, I guess we need to land it in gemfile: ['rails_5_2', 'rails_6_0', 'rails_6_1', 'rails_7_0', 'rails_7_1'] too, in the darned CI workflow YAML.

olleolleolle commented 1 month ago

Ah, right, some limits on Ruby/Rails versions for exclude/include

Because railties >= 7.2.0.beta1 depends on Ruby >= 3.1.0
  and rails_7_2.gemfile depends on railties ~> 7.2.1,
  Ruby >= 3.1.0 is required.
So, because current Ruby version is = 3.0.7,
  version solving has failed.

Thanks for chasing this!

p8 commented 1 month ago

@olleolleolle I've added Ruby 3.3 to the matrix as well.

olleolleolle commented 1 month ago

@p8 Thank you for this!

p8 commented 1 month ago

Thanks @olleolleolle !

luke-hill commented 1 month ago

Thanks for bringing this to my attention. Per the comments I need to do a bit of cleanup here. I'll get this done soon because it can just go in a patch release with some minor tidies I'll do in the codebase proper