Refactor/simplify test matrix - Githubissues

cucumber / cucumber-rails

Rails Generators for Cucumber with special support for Capybara and DatabaseCleaner

https://github.com/cucumber/cucumber-rails

MIT License

1.02k stars 327 forks source link

Refactor/simplify test matrix #588

Open luke-hill opened 3 weeks ago

luke-hill commented 3 weeks ago

🤔 What's changed?

Follow up from previous work in #586 to explain the decisions. Move to an include/exclude matrix to cover old/new rubies vs standard ones

⚡️ What's your motivation?

Explain the choices of what combinations to run plus simplify things a little (Removing some redundant combinations in the process).

🏷️ What kind of change is this?

:book: Documentation (improvements without changing code)
:bank: Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct
[ ] I've changed the behaviour of the code
- [ ] I have added/updated tests to cover my changes.
[ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
[ ] Users should know about my change
- [ ] I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

luke-hill commented 3 weeks ago

cc/ @p8 / @olleolleolle for some updates here (We actually reduce the size of the matrix, but build it in a slightly diff way so you can see "how" it is built better).