Add Rails 8 compatibility - Githubissues

cucumber / cucumber-rails

Rails Generators for Cucumber with special support for Capybara and DatabaseCleaner

https://github.com/cucumber/cucumber-rails

MIT License

1.03k stars 327 forks source link

Add Rails 8 compatibility #590

Closed tagliala closed 5 days ago

tagliala commented 2 weeks ago

In specific:

Do not test Rails 7.0 against 3.3
Allow 8.0 in gemspec, by relaxing the upper constraint to < 8.1. Rails uses shifted SemVer, so 8.1 is considered a Major.
Conditionally load the sqlite3 gem based on the Rails version.
Conditionally load selenium webdriver gem based on the Rails version.
Simplify error page assertions to account for variations in apostrophes, as "We're sorry" changed to "We`re sorry" in Rails 8.

References:

https://guides.rubyonrails.org/maintenance_policy.html#versioning
rails/rails#53045

Close #589

CI: https://github.com/tagliala/cucumber-rails/actions/runs/11764599692/job/32769937431

ActiveAdmin CI against the fork (7.0, 7.1, 7.2, 8.0): https://github.com/activeadmin/activeadmin/actions/runs/11764550754/job/32769831332

🤔 What's changed?

Rails 8.0 compatibility

⚡️ What's your motivation?

Unexpected downgrade to 1.4 after upgrading to Rails 8.x

🏷️ What kind of change is this?

:zap: New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

n/a

📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct
[x] I've changed the behaviour of the code
- [x] I have added/updated tests to cover my changes.
[x] My change requires a change to the documentation.
- [x] I have updated the documentation accordingly.
[x] Users should know about my change
- [x] I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.