search

cucumber / cucumber-ruby-wire

Wire protocol plugin for Cucumber
MIT License
7 stars 11 forks source link

Don't restrict Travis to master and prevent notifying cuke-devs about private forks #12

Closed muggenhor closed 3 years ago

muggenhor commented 7 years ago

Removing the restriction of building master only seems only sensible: there's no other branch, so no point in restricting what gets build. This currently prevents people with their own fork from getting builds on Travis unless they change this part in Travis configuration, and then try not to submit that in a PR.

Removing the cukes-dev notification is because this will only result in spamming the cukes-dev list with every built done on a private fork, for no good reason at all. The default notification targets (committer and commit author) are good enough ( https://docs.travis-ci.com/user/notifications#Default-notification-settings ).

luke-hill commented 5 years ago

Hi @muggenhor can you rebase this branch and I'll approve and merge it, as it's a simple change.