cucumber / gherkin-utils

API for working with Gherkin documents
MIT License
9 stars 4 forks source link

Fix rule filtering in the document walker #17

Closed mclem closed 6 months ago

mclem commented 1 year ago

🤔 What's changed?

Rules are now filtered when their all their children (background and scenarios) are themselves filtered.

⚡️ What's your motivation?

Fix for https://github.com/cucumber/react-components/issues/136

🏷️ What kind of change is this?

♻️ Anything particular you want feedback on?

I have no experience in TypeScript so I'm not sure about the fix. It seems that the bug was about a difference in handling of undefined vs null. Please feel free to modify anything as required.

📋 Checklist:


This text was originally generated from a template, then edited by hand. You can modify the template here.

luke-hill commented 6 months ago

@mpkorstanje / @Dbuggerx can this now be closed?

mpkorstanje commented 6 months ago

Superseded by https://github.com/cucumber/gherkin-utils/pull/48