Closed blacelle closed 1 year ago
This is contextual to the integration of this library into Spotless https://github.com/diffplug/spotless/pull/1649
Just a quick note @blacelle that I'm working on a related PR for javascript/
and I've recently restored a bunch of *.feature
test fixtures that the JS unit tests employ. These files existed in the monorepo, and got missed when gherkin-utils
was moved into its own repo. They may be relevant to your PR.
Thanks @xeger . This PR is ready since a month, but it seems there is no maintainer to review it.
@mpkorstanje As you reviewed #16, please have a look to this PR. Thanks
@xeger @aslakhellesoy How can I move forward with this PR?
Hi @blacelle,
Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾
In return for this generous offer we hope you will:
On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber
Thanks a lot @xeger
Thank you for your contribution. I'll work on releasing a new JAR over the weekend.
This follows the work from https://github.com/cucumber/common/pull/2024 (Thanks @jamietanna ).
It proposes improvments for comments rendering. This is not perfect, but looks better than current behavior (especially over comments after a
@Tag
,Scenario
, etc).