search

cucumber / gherkin

A parser and compiler for the Gherkin language.
MIT License
188 stars 62 forks source link

C++ implementation #117

Closed chybz closed 1 year ago

chybz commented 1 year ago

🤔 What's changed?

⚡️ What's your motivation?

🏷️ What kind of change is this?

♻️ Anything particular you want feedback on?

This text was originally generated from a template, then edited by hand. You can modify the template here.

mpkorstanje commented 1 year ago

If I've not done it wrong, you should now be able to push and that will trigger CI.

chybz commented 1 year ago

Thanks a lot ! From what I saw, compile process got "Terminated" (killed), certainly because of C++ compile RAM usage. Will investigate that tomorrow.

TheKayneGame commented 1 year ago

Any Updates Regarding this PR?

chybz commented 1 year ago

@TheKayneGame apart from the minor conflicts in the two Markdown files that occurred recently, I couldn't merge this PR about 4 months ago when @mpkorstanje kindly gave me access (I also worked on the messages C++ implementation). Could you please tell me what's missing ?

TheKayneGame commented 1 year ago

@chybz First of all thanks for the hard work. The reason i ask this question is because this PR seems to have been open for all this time. and i was afraid it might have gone stale of something.

My main question is: Will this PR ever be merged?

chybz commented 1 year ago

That is indeed my only goal atm. Last time I tried, I was not allowed to do so. I'll fix the small conflicts today and give it another go and keep you informed.

TheKayneGame commented 1 year ago

Why has this been closed now?

chybz commented 1 year ago

I erroneously rebase a wrong local branch in my repo. I trashed all of it, and restarted from scratch on another (now merged) PR.

Sorry for all that noise.