cucumber / gherkin

A parser and compiler for the Gherkin language.
MIT License
188 stars 62 forks source link

Python: Automate releases #148

Closed ehuelsmann closed 10 months ago

ehuelsmann commented 1 year ago

Same as cucumber/tag-expressions#20 and related to #62, @aslakhellesoy noted:

We've adopted a release process based on GitHub Actions - documented in RELEASING.md

In order to automate Python releases, we need a new .github/workflows/release-pypi.yml

ehuelsmann commented 1 year ago

https://github.com/cucumber/action-publish-pypi exists and can be integrated..

ehuelsmann commented 1 year ago

@jenisys when you're looking at tag-expressions, please have a look at this project too.

ehuelsmann commented 1 year ago

Also take #40 into account.

jenisys commented 1 year ago

@ehuelsmann I just looked at it. I think I do not have the sufficient rights for this project that is registered with https://pypi.org . Only @aslakhellesoy and the cukebot are registered as maintainers. If Aslak can register me there as maintainer, then I could perform the necessary steps (or Aslak can perform the necessary steps).

NOTE: This is different with tag-expressions. Because I created this project on https://pypi.org , I am also the maintainer (and added Aslak afterwards as maintainer). Therefore, there I can create the necessary build-token that can be used later-on.

SEE ALSO:

aslakhellesoy commented 1 year ago

The automated release process outlined in https://github.com/cucumber/.github/blob/main/RELEASING.md uses the cukebot account for releases. We made a decision a while ago to avoid using personal accounts.

What's preventing you from using the automated release process @jenisys?

rgilton commented 11 months ago

Would resolving this issue get the version of gherkin that's on pypi up to the latest? The version that's up there seems to be quite out of date (24.1.0 vs the current latest v27.0.0).

mpkorstanje commented 11 months ago

PiPy credentials have been restored.

So now it comes down to merging and possibly updating https://github.com/cucumber/gherkin/pull/62 but we don't have any dedicated Python maintainers in the core team so it may take a while.

brasmusson commented 10 months ago

Fixed with #213