cucumber / gherkin

A parser and compiler for the Gherkin language.
MIT License
175 stars 54 forks source link

Perl harmonized errors #149

Closed ehuelsmann closed 1 year ago

ehuelsmann commented 1 year ago

🤔 What's changed?

Test suite for parse errors is now run too.

⚡️ What's your motivation?

Consistency. The rest is explained in #31.

🏷️ What kind of change is this?

:bug: Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

I think this is a minor version at most: the only difference in behaviour is the error code path, which now results in Cucumber Messages (in most cases) instead of exceptions to be caught.

The fact that the exceptions don't auto-stringify anymore doesn't look like a major issue, because they used to be immediately stringified when being thrown (throwing and having a stringification method turn out to be incompatible).

📋 Checklist:

ehuelsmann commented 1 year ago

Changelog still to come, obviously.

ehuelsmann commented 1 year ago

After consulting with @mpkorstanje, he'll review in hindsight, if he wants to.