Remove duplicate token matcher Python code - Githubissues

cucumber / gherkin

A parser and compiler for the Gherkin language.

MIT License

160 stars 48 forks source link

Remove duplicate token matcher Python code #205

Closed kieran-ryan closed 5 months ago

kieran-ryan commented 5 months ago

🤔 What's changed?

Change Python implementation of markdown token matcher to inherit from feature file token matcher.

⚡️ What's your motivation?

Remove duplicated code - ensuring a source of truth and improved maintainability.
Add missing entry in manifest for markdown token matcher - added automatically as part of build process when running test suite through tox

Existing test suite remained compatible for the feature file and markdown matchers after the change - including with Python 2.

🏷️ What kind of change is this?

:bank: Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

NA.

📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct
[x] I've changed the behaviour of the code
[x] Users should know about my change
- [x] I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

mpkorstanje commented 5 months ago

Cheers!