cucumber / gherkin

A parser and compiler for the Gherkin language.
MIT License
160 stars 48 forks source link

Fix cpp build #206

Closed mpkorstanje closed 5 months ago

mpkorstanje commented 5 months ago

🤔 What's changed?

Pinned messages to v24.0.1.

⚡️ What's your motivation?

CI Breaks with

https://github.com/cucumber/gherkin/actions/runs/7368444336/job/20053098978

CMake Error at CMakeLists.txt:13 (find_package):
  Could not find a package configuration file provided by "cucumber-messages"
  with any of the following names:

    cucumber-messagesConfig.cmake
    cucumber-messages-config.cmake

  Add the installation prefix of "cucumber-messages" to CMAKE_PREFIX_PATH or
  set "cucumber-messages_DIR" to a directory containing one of the above
  files.  If "cucumber-messages" provides a separate development package or
  SDK, be sure it has been installed.

Presumably because of https://github.com/cucumber/messages/pull/187

🏷️ What kind of change is this?

♻️ Anything particular you want feedback on?

A proper fundamental fix would be nice, but if this passes CI we can continue with other PRs.

📋 Checklist:


chybz commented 5 months ago

Having look asap