Closed renovate[bot] closed 3 months ago
renovate[bot]
commented
5 months ago This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.
olleolleolle
commented
4 months ago So, the build failure here is actually Psalm complaining about legitimate PHP things.
src/PickleCompiler.php:255:24: RiskyTruthyFalsyComparisonOperand of type null|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356) Error: src/TokenFormatter.php:20:13: RiskyTruthyFalsyComparison: Operand of type null|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)2 errors found
Psalm can automatically fix 1 of these issues. Run Psalm again with --alter --issues=MissingParamType --dry-run to see what it can fix.
renovate[bot]
commented
3 months ago Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.
This PR contains the following updates:
5.19.1->5.23.1Release Notes
vimeo/psalm (vimeo/psalm)
### [`v5.23.1`](https://togithub.com/vimeo/psalm/releases/tag/5.23.1) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.23.0...5.23.1) #### What's Changed ##### Fixes - Fixed analysis of existing static methods if the `__callStatic()` method exists by [@issidorov](https://togithub.com/issidorov) in [https://github.com/vimeo/psalm/pull/10812](https://togithub.com/vimeo/psalm/pull/10812) **Full Changelog**: https://github.com/vimeo/psalm/compare/5.23.0...5.23.1 ### [`v5.23.0`](https://togithub.com/vimeo/psalm/releases/tag/5.23.0) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.22.2...5.23.0) #### What's Changed ##### Features - Update PHP 8.2 stubs to include `SensitiveParameterValue` by [@gsteel](https://togithub.com/gsteel) in [https://github.com/vimeo/psalm/pull/10726](https://togithub.com/vimeo/psalm/pull/10726) - Add list of statements to BeforeFileAnalysisEvent by [@ohader](https://togithub.com/ohader) in [https://github.com/vimeo/psalm/pull/10728](https://togithub.com/vimeo/psalm/pull/10728) - Forbid iterating over generators with non-nullable `send()` by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10697](https://togithub.com/vimeo/psalm/pull/10697) - Initial support for named parameters for callables by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10772](https://togithub.com/vimeo/psalm/pull/10772) ##### Fixes - Improve randomizer stubs by [@danog](https://togithub.com/danog) in [https://github.com/vimeo/psalm/pull/10709](https://togithub.com/vimeo/psalm/pull/10709) - Fix detecting magic static methods by [@issidorov](https://togithub.com/issidorov) in [https://github.com/vimeo/psalm/pull/10704](https://togithub.com/vimeo/psalm/pull/10704) - Fix non-empty-lowercase-string handling with literal non-lowercase strings by [@kkmuffme](https://togithub.com/kkmuffme) in [https://github.com/vimeo/psalm/pull/10722](https://togithub.com/vimeo/psalm/pull/10722) - Fix RiskyTruthyFalsyComparison irrelevant errors when there is no explicit truthy/falsy type by [@kkmuffme](https://togithub.com/kkmuffme) in [https://github.com/vimeo/psalm/pull/10733](https://togithub.com/vimeo/psalm/pull/10733) - Allow `Override` attribute to be used in pure contexts by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10734](https://togithub.com/vimeo/psalm/pull/10734) - Revert "Allow tainted numerics except for 'html' and 'has_quotes'" by [@ohader](https://togithub.com/ohader) in [https://github.com/vimeo/psalm/pull/10729](https://togithub.com/vimeo/psalm/pull/10729) - Fix loading stubs from phar file on Windows by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10748](https://togithub.com/vimeo/psalm/pull/10748) - Fix a false flag issue with InvalidConstantAssignmentValue by [@MelechMizrachi](https://togithub.com/MelechMizrachi) in [https://github.com/vimeo/psalm/pull/10738](https://togithub.com/vimeo/psalm/pull/10738) - Set inside_isset false when analyzing ArrayDimFetch index by [@edsrzf](https://togithub.com/edsrzf) in [https://github.com/vimeo/psalm/pull/10752](https://togithub.com/vimeo/psalm/pull/10752) - Set inside_isset = false when analyzing arguments by [@edsrzf](https://togithub.com/edsrzf) in [https://github.com/vimeo/psalm/pull/10753](https://togithub.com/vimeo/psalm/pull/10753) - Fix PHP notice - crash on invalid taint-escape by [@kkmuffme](https://togithub.com/kkmuffme) in [https://github.com/vimeo/psalm/pull/10760](https://togithub.com/vimeo/psalm/pull/10760) - Fix version comparison for `@since` by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10764](https://togithub.com/vimeo/psalm/pull/10764) - Since annotations outside phpstub should not infer php version by [@kkmuffme](https://togithub.com/kkmuffme) in [https://github.com/vimeo/psalm/pull/10769](https://togithub.com/vimeo/psalm/pull/10769) - Backport `WeakMap` iterator fix from `master` by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10778](https://togithub.com/vimeo/psalm/pull/10778) - Namespace anonymous classes by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10779](https://togithub.com/vimeo/psalm/pull/10779) - Update CallMap for sqlsrv_connect and sqlsrv_errors to match reflection by [@theodorejb](https://togithub.com/theodorejb) in [https://github.com/vimeo/psalm/pull/10781](https://togithub.com/vimeo/psalm/pull/10781) - `$resource` parameter of `mkdir()` is nullable since PHP 7.3 by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10802](https://togithub.com/vimeo/psalm/pull/10802) - Use wider class-string when combining class strings with intersections by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10800](https://togithub.com/vimeo/psalm/pull/10800) ##### Internal changes - Use TaintKind/TaintKindGroup constants instead of string values by [@ohader](https://togithub.com/ohader) in [https://github.com/vimeo/psalm/pull/10746](https://togithub.com/vimeo/psalm/pull/10746) - Skip symlink test on Windows by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10749](https://togithub.com/vimeo/psalm/pull/10749) - Avoid duplicating code for RiskyTruthyFalsyComparison by [@theodorejb](https://togithub.com/theodorejb) in [https://github.com/vimeo/psalm/pull/10765](https://togithub.com/vimeo/psalm/pull/10765) - fix PHP 8 tests running with wrong --php-version=/phpVersion= if not explicitly specified by [@kkmuffme](https://togithub.com/kkmuffme) in [https://github.com/vimeo/psalm/pull/10776](https://togithub.com/vimeo/psalm/pull/10776) - CS fix by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10801](https://togithub.com/vimeo/psalm/pull/10801) #### New Contributors - [@MelechMizrachi](https://togithub.com/MelechMizrachi) made their first contribution in [https://github.com/vimeo/psalm/pull/10738](https://togithub.com/vimeo/psalm/pull/10738) **Full Changelog**: https://github.com/vimeo/psalm/compare/5.22.2...5.23.0 ### [`v5.22.2`](https://togithub.com/vimeo/psalm/releases/tag/5.22.2) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.22.1...5.22.2) #### What's Changed ##### Fixes - Catch missing classlike exceptions during scanning by [@weirdan](https://togithub.com/weirdan) and [@ohader](https://togithub.com/ohader) in [https://github.com/vimeo/psalm/pull/10720](https://togithub.com/vimeo/psalm/pull/10720) **Full Changelog**: https://github.com/vimeo/psalm/compare/5.22.1...5.22.2 ### [`v5.22.1`](https://togithub.com/vimeo/psalm/releases/tag/5.22.1) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.22.0...5.22.1) #### What's Changed ##### Fixes - Improve parsing of `@psalm-type` by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10713](https://togithub.com/vimeo/psalm/pull/10713) **Full Changelog**: https://github.com/vimeo/psalm/compare/5.22.0...5.22.1 ### [`v5.22.0`](https://togithub.com/vimeo/psalm/releases/tag/5.22.0) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.21.1...5.22.0) #### What's Changed ##### Features - Allow inline comments in typedef shapes by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10623](https://togithub.com/vimeo/psalm/pull/10623) - allow typedef imports from any kind of classlike by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10625](https://togithub.com/vimeo/psalm/pull/10625) - Allow enum cases to be global constants by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10634](https://togithub.com/vimeo/psalm/pull/10634) - New InvalidOverride issue for Override attribute by [@edsrzf](https://togithub.com/edsrzf) in [https://github.com/vimeo/psalm/pull/10644](https://togithub.com/vimeo/psalm/pull/10644) - Analyze dynamic names for static property and const fetches by [@edsrzf](https://togithub.com/edsrzf) in [https://github.com/vimeo/psalm/pull/10629](https://togithub.com/vimeo/psalm/pull/10629) - New MissingOverrideAttribute issue by [@edsrzf](https://togithub.com/edsrzf) in [https://github.com/vimeo/psalm/pull/10651](https://togithub.com/vimeo/psalm/pull/10651) - Flag `stdClass::__construct()` calls that have arguments by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10661](https://togithub.com/vimeo/psalm/pull/10661) - Improve Reflection stubs by [@vudaltsov](https://togithub.com/vudaltsov) in [https://github.com/vimeo/psalm/pull/10091](https://togithub.com/vimeo/psalm/pull/10091) - Forbid constructors from returning any values by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10686](https://togithub.com/vimeo/psalm/pull/10686) - Report first class callables generated for unknown static methods by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10691](https://togithub.com/vimeo/psalm/pull/10691) - Process `@psalm-this-out` on `__construct()` as well by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10690](https://togithub.com/vimeo/psalm/pull/10690) - Report invalid number of arguments for psalm-taint-\* by [@staabm](https://togithub.com/staabm) in [https://github.com/vimeo/psalm/pull/10699](https://togithub.com/vimeo/psalm/pull/10699) ##### Fixes - Fix ownerDocument type in dom-ext classes by [@fluffycondor](https://togithub.com/fluffycondor) in [https://github.com/vimeo/psalm/pull/10619](https://togithub.com/vimeo/psalm/pull/10619) - Fix numeric scalar validate filter var input return type wrong by [@kkmuffme](https://togithub.com/kkmuffme) in [https://github.com/vimeo/psalm/pull/10621](https://togithub.com/vimeo/psalm/pull/10621) - Stable baseline by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10633](https://togithub.com/vimeo/psalm/pull/10633) - Allow sebastian/diff v6 by [@simPod](https://togithub.com/simPod) in [https://github.com/vimeo/psalm/pull/10639](https://togithub.com/vimeo/psalm/pull/10639) - CallMap: Adjust return type for `inotify_add_watch()` to `int|false` by [@UlrichEckhardt](https://togithub.com/UlrichEckhardt) in [https://github.com/vimeo/psalm/pull/10637](https://togithub.com/vimeo/psalm/pull/10637) - Fix check-type when using builtin types from within a namespace by [@robchett](https://togithub.com/robchett) in [https://github.com/vimeo/psalm/pull/10648](https://togithub.com/vimeo/psalm/pull/10648) - Do not add `callable` as a native property type by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10654](https://togithub.com/vimeo/psalm/pull/10654) - Fix additional places where base_dir was broken due to missing separator by [@kkmuffme](https://togithub.com/kkmuffme) in [https://github.com/vimeo/psalm/pull/10630](https://togithub.com/vimeo/psalm/pull/10630) - Late binding of enum cases by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10655](https://togithub.com/vimeo/psalm/pull/10655) - Suppress `UndefinedClass` in `whatever_exists()` by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10659](https://togithub.com/vimeo/psalm/pull/10659) - Fix parsing magic method annotations by [@issidorov](https://togithub.com/issidorov) in [https://github.com/vimeo/psalm/pull/10665](https://togithub.com/vimeo/psalm/pull/10665) - Strip callmap prefixes from parameter names by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10666](https://togithub.com/vimeo/psalm/pull/10666) - Narrow `ord()` return type to `int<0,255>` by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10676](https://togithub.com/vimeo/psalm/pull/10676) - Template union object incorrect assertions by [@robchett](https://togithub.com/robchett) in [https://github.com/vimeo/psalm/pull/10677](https://togithub.com/vimeo/psalm/pull/10677) - Don't show backtrace in `InvalidDocblock` issue message by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10679](https://togithub.com/vimeo/psalm/pull/10679) - Class consts in array shapes by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10678](https://togithub.com/vimeo/psalm/pull/10678) - Prevent mixed|null by [@robchett](https://togithub.com/robchett) in [https://github.com/vimeo/psalm/pull/10675](https://togithub.com/vimeo/psalm/pull/10675) ##### Internal changes - Drop unused local composer repo by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10647](https://togithub.com/vimeo/psalm/pull/10647) - Clarify that Pull request labels failure is to be resolved by maintainers by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10649](https://togithub.com/vimeo/psalm/pull/10649) - Fix unstable `hasFullyQualified(Interface|Enum)()` by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10603](https://togithub.com/vimeo/psalm/pull/10603) - Revert partial mistakenly pushed fix by [@danog](https://togithub.com/danog) in [https://github.com/vimeo/psalm/pull/10671](https://togithub.com/vimeo/psalm/pull/10671) **Full Changelog**: https://github.com/vimeo/psalm/compare/5.21.1...5.22.0 ### [`v5.21.1`](https://togithub.com/vimeo/psalm/releases/tag/5.21.1) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.21.0...5.21.1) #### What's Changed ##### Fixes - Fix baseline loading for path specified on the command line by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10628](https://togithub.com/vimeo/psalm/pull/10628) **Full Changelog**: https://github.com/vimeo/psalm/compare/5.21.0...5.21.1 ### [`v5.21.0`](https://togithub.com/vimeo/psalm/releases/tag/5.21.0) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.20.0...5.21.0) #### What's Changed ##### Features - Allow importing typedefs from enums by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10617](https://togithub.com/vimeo/psalm/pull/10617) ##### Fixes - Fix [#10552](https://togithub.com/vimeo/psalm/issues/10552) by [@danog](https://togithub.com/danog) in [https://github.com/vimeo/psalm/pull/10572](https://togithub.com/vimeo/psalm/pull/10572) - Unit test improvements for php-parser 5 by [@edsrzf](https://togithub.com/edsrzf) in [https://github.com/vimeo/psalm/pull/10574](https://togithub.com/vimeo/psalm/pull/10574) - Fix template replacement edge case by [@klimick](https://togithub.com/klimick) in [https://github.com/vimeo/psalm/pull/10586](https://togithub.com/vimeo/psalm/pull/10586) - Switch condition order by [@edsrzf](https://togithub.com/edsrzf) in [https://github.com/vimeo/psalm/pull/10594](https://togithub.com/vimeo/psalm/pull/10594) - Partial revert "Fix auto completion by partial property or method" by [@issidorov](https://togithub.com/issidorov) in [https://github.com/vimeo/psalm/pull/10588](https://togithub.com/vimeo/psalm/pull/10588) - \[LSP] Add issue type in description by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10607](https://togithub.com/vimeo/psalm/pull/10607) - Do not validate callable arguments in lenient contexts by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10601](https://togithub.com/vimeo/psalm/pull/10601) - `readgzfile()` is impure by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10600](https://togithub.com/vimeo/psalm/pull/10600) - Allow properties on intersections with enum interfaces by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10599](https://togithub.com/vimeo/psalm/pull/10599) - `key_exists()` is an alias for `array_key_exists()` by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10598](https://togithub.com/vimeo/psalm/pull/10598) - Fix language server running with `opcache.save_comments=0` by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10614](https://togithub.com/vimeo/psalm/pull/10614) - Report `MissingConstructor` for natively typed mixed properties by [@weirdan](https://togithub.com/weirdan) in [https://github.com/vimeo/psalm/pull/10615](https://togithub.com/vimeo/psalm/pull/10615) ##### Internal changes - Bump actions/cache from 3 to 4 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/vimeo/psalm/pull/10584](https://togithub.com/vimeo/psalm/pull/10584) - Baseline update by [@jorgsowa](https://togithub.com/jorgsowa) in [https://github.com/vimeo/psalm/pull/10593](https://togithub.com/vimeo/psalm/pull/10593) - Re-work CheckTrivialExprVisitor by [@edsrzf](https://togithub.com/edsrzf) in [https://github.com/vimeo/psalm/pull/10612](https://togithub.com/vimeo/psalm/pull/10612) - Minor php-parser tweaks by [@edsrzf](https://togithub.com/edsrzf) in [https://github.com/vimeo/psalm/pull/10605](https://togithub.com/vimeo/psalm/pull/10605) #### New Contributors - [@jorgsowa](https://togithub.com/jorgsowa) made their first contribution in [https://github.com/vimeo/psalm/pull/10593](https://togithub.com/vimeo/psalm/pull/10593) **Full Changelog**: https://github.com/vimeo/psalm/compare/5.20.0...5.21.0 ### [`v5.20.0`](https://togithub.com/vimeo/psalm/releases/tag/5.20.0) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.19.1...5.20.0) #### What's Changed ##### Features - report error for non-strict or empty comparison on truthy+falsy union by [@kkmuffme](https://togithub.com/kkmuffme) in [https://github.com/vimeo/psalm/pull/10502](https://togithub.com/vimeo/psalm/pull/10502) ##### Fixes - Fix template, conditional array keys by [@danog](https://togithub.com/danog) in [https://github.com/vimeo/psalm/pull/10568](https://togithub.com/vimeo/psalm/pull/10568) **Full Changelog**: https://github.com/vimeo/psalm/compare/5.19.1...5.20.0Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.