CI: Update latest PHP version to last non-EOL version - Githubissues

cucumber / gherkin

A parser and compiler for the Gherkin language.

MIT License

160 stars 48 forks source link

CI: Update latest PHP version to last non-EOL version #228

Closed olleolleolle closed 4 months ago

olleolleolle commented 4 months ago

🤔 What's changed?

Went from 8.1 to 8.2.

⚡️ What's your motivation?

8.1 is EOL. 8.2 is still supported.

When reading https://phpunit.de/announcements/phpunit-11.html I saw that since Feb 2 2024, 8.2 is the oldest still-supported PHP version.

🏷️ What kind of change is this?

:bank: Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

-

📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct

mpkorstanje commented 4 months ago

I suppose it would also be prudent to update the minimum version in composer aswell. Could you do that and include an item in the release notes under the ### Changed header?

https://github.com/cucumber/gherkin/blob/main/php/composer.json#L16