This PR is an experiment run, to see if Psalm's "find unused" can be tamed, to become useful.
⚡️ What's your motivation?
Psalm seems like a cool tool.
🏷️ What kind of change is this?
:bank: Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)
♻️ Anything particular you want feedback on?
Is this a viable path?
I downgraded a Property in a constructor to a regular positional parameter – this was due to a Psalm warning. Is that reasonable?
One error handler dealt with return values, when it looked like that wasn't what it usually did. I turned it into a regular "callbacky" thing, instead.
Well, any thoughts around keeping these Psalm checks enabled would be welcome. Also thoughts around "why this does not suit Gherkin".
🤔 What's changed?
This PR is an experiment run, to see if Psalm's "find unused" can be tamed, to become useful.
⚡️ What's your motivation?
Psalm seems like a cool tool.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Is this a viable path?
I downgraded a Property in a constructor to a regular positional parameter – this was due to a Psalm warning. Is that reasonable?
One error handler dealt with return values, when it looked like that wasn't what it usually did. I turned it into a regular "callbacky" thing, instead.
Well, any thoughts around keeping these Psalm checks enabled would be welcome. Also thoughts around "why this does not suit Gherkin".
📋 Checklist: