cucumber / gherkin

A parser and compiler for the Gherkin language.
MIT License
188 stars 62 forks source link

Python does not keep version in pyproject.toml #289

Closed mpkorstanje closed 1 month ago

mpkorstanje commented 1 month ago

🤔 What's the problem you've observed?

Releases are made with a script. This is necessary because nobody can remember the intricacies and conflicting requirements of releasing (currently) 13 different languages.

So for the sake of the sanity of everyone involved in the release there should be exactly one conventional location for every python project in the Cucumber org to keep its version.

Currently the preferred place is directly in pyproject.toml.

For Gherkin currently the version is kept in setup.py.

https://github.com/cucumber/gherkin/blob/76333135e9a418d00d5fe0ff994262dae7dc5910/python/setup.py#L6

✨ Do you have a proposal for making it better?

Keep the version in pyproject.toml.

📚 Any additional context?

I am open to better ways of doing this, but then I'd like to see a set of merge requests apply that change to all repositories at once.

So for the short term it I'd be best to use pyproject.toml.

youtux commented 1 month ago

Done in https://github.com/cucumber/gherkin/pull/290

jsa34 commented 1 month ago

Resolved in commit https://github.com/cucumber/gherkin/commit/24296c19083053b3c612b9c33a007e654a8fd657

mpkorstanje commented 1 month ago

Cheers!