cucumber / gherkin

A parser and compiler for the Gherkin language.
MIT License
187 stars 63 forks source link

French equivalent of `Given` is invariable #9

Open ecattez opened 2 years ago

ecattez commented 2 years ago

🤔 What's the problem you're trying to solve?

The equivalent of Given in French is invariable. It should be Etant donné or Etant donné que only.

✨ What's your proposed solution?

Remove all existing sentences, other than Etant donné and Etant donné que:

⛏ Have you considered any alternatives or workarounds?

Let people write French like they want, but that would be direspectful for the language.


This text was originally generated from a template, then edited by hand. You can modify the template here.

mpkorstanje commented 2 years ago

Cucumber JVM generates the annotations based on Gherkin. So I'm moving this to the common repo.

The translations can be found in:

https://github.com/cucumber/common/blob/main/gherkin/gherkin-languages.json#L1308

aslakhellesoy commented 2 years ago

@ecattez @fdelbrayelle how would you translate the following English step to French:

Given the following cars:
  | year | car                        |
  | 1936 | Bugatti Type 57SC Atlantic |
  | 1948 | Tucker Torpedo             |

I would write it like this:

Étant données les voitures suivantes:
  |  année | voiture                    |
  |   1936 | Bugatti Type 57SC Atlantic |
  |   1948 | Tucker Torpedo             |

I am not a native French speaker so I might have something to learn about grammar here...

aslakhellesoy commented 2 years ago

/cc @boucardbruno and @jbpros who added this translation here: https://github.com/cucumber-attic/gherkin2/compare/v2.5.1...v2.5.2

ecattez commented 2 years ago

Hello @aslakhellesoy.

It would be Étant donné les voitures suivantes. It's a particular thing of French grammar called '' preposition ''. If it was after the car, it would be Les voitures suivantes étant données.

You could find more info here : https://www.larousse.fr/dictionnaires/francais/%C3%A9tant_donn%C3%A9/31312

aslakhellesoy commented 2 years ago

Wow you learn something new every day. I’m all for removing the grammatically incorrect synonyms, but it would require a major release of Gherkin (and anything depending on it).

ecattez commented 2 years ago

I agree. Maybe we could deprecate all wrong synonyms before removing them?

aslakhellesoy commented 2 years ago

It’s deprecate :-). We don’t have a deprecation mechanism for keywords. Maybe we should make one…

ecattez commented 2 years ago

If it does not happen often, such a mechanism is not necessary, IMO

ciaranmcnulty commented 2 years ago

@stof

jbpros commented 2 years ago

/cc @boucardbruno and @jbpros who added this translation here: cucumber-attic/gherkin2@v2.5.1...v2.5.2

Désolé! 🤓

I must say, now that I see it, I’m embarrassed I let that mistake go through!

ecattez commented 2 years ago

It happens. I'm French native and I discovered that rule few days ago. So we were wrong writing scenarios in team 😅

ciaranmcnulty commented 2 years ago

I think 'people may write the scenario like this' is more important than grammatical purity though?