radtriste commented 4 years ago

And created interface GherkinFeature to allow to retrieve the main Gherkin information.

https://github.com/cucumber/godog/issues/222

Following https://github.com/cucumber/godog/pull/223 and migration to new Gherkin structure.

codecov[bot] commented 4 years ago

Codecov Report

Merging #276 (20ab6fc) into main (3de6fb0) will increase coverage by 1.89%. The diff coverage is 100.00%.

:exclamation: Current head 20ab6fc differs from pull request most recent head 5566c15. Consider uploading reports for the commit 5566c15 to get more accurate results

@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
+ Coverage   82.30%   84.19%   +1.89%     
==========================================
  Files          26       16      -10     
  Lines        2368     2468     +100     
==========================================
+ Hits         1949     2078     +129     
+ Misses        309      271      -38     
- Partials      110      119       +9

Impacted Files	Coverage Δ
suite.go	`87.91% <100.00%> (-2.82%)`	:arrow_down:
fmt.go	`94.40% <0.00%> (-5.60%)`	:arrow_down:
run.go	`79.33% <0.00%> (-4.47%)`	:arrow_down:
internal/formatters/fmt_junit.go
internal/flags/flags.go
internal/formatters/fmt_progress.go
internal/formatters/fmt_multi.go
internal/models/feature.go
formatters/fmt.go
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3de6fb0...5566c15. Read the comment docs.

lonnblad commented 4 years ago

@radtriste thanks for the PR, it would be good to get some tests for this as well

radtriste commented 4 years ago

That I will write :)

radtriste commented 4 years ago

@lonnblad is that what you meant ? (see my changes)

radtriste commented 4 years ago

any news on that one ?

mattwynne commented 2 years ago

@radtriste so sorry for the delay getting this merged. Would you be able to help rebase it, then we can get it merged in?

radtriste commented 2 years ago

@mattwynne sure will try to rebase in the next days !

radtriste commented 2 years ago

@mattwynne @lonnblad let me know what you think of the change. I directly setup a method on the Test Suite to retrieve the features. This method is independent from the Run and should not have any impact on it

aslakhellesoy commented 2 years ago

Hi @radtriste,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber

mattwynne commented 2 years ago

Thanks @radtriste. I've merged your PR without a very thorough review as we're short on regular maintainers at the moment. Now that you have the commit bit 🎉 it would be awesome if you had any time to help us with that problem. No pressure! ❤️

radtriste commented 2 years ago

@mattwynne Cannot promise anything but can keep an eye on godog project for now

cucumber / godog

Added GetGherkinFeatures method to godog.Suite #276

Codecov Report