search

cucumber / godog

Cucumber for golang
MIT License
2.32k stars 254 forks source link

Implement message formatter #341

Open aslakhellesoy opened 4 years ago

aslakhellesoy commented 4 years ago

The Cucumber JSON format is deprecated in Cucumber-Ruby, Cucumber-JVM and Cucumber-js. The recommended replacement is cucumber-messages.

It would be great to implement support for this in godog, and deprecate the cucumber formatter (The other Cucumber implementations call it the json formatter).

aslakhellesoy commented 4 years ago

Related issues: #338 #124 #205

Johnlon commented 6 months ago

@aslakhellesoy (and @dumpsterfireproject ) - I see this ticket is still open - confusingly I can also see that there is a formatter "events" in the code base and I'd assumed initially that the "event" format was the same as the "message" format defined in messages.go and formatted in the jdjson style of cucumer jvm.

BUT the "events" formatter doesn't conform at all to the cucumber/messages definitions in messages.go.

For example

And the events in the generated file when using the "events" formatter aren't the ndjson style I was expecting but something else.

It's perhaps significant that the godog code doesn't acrually refer to the types in messages.go other than by string name, never by type.

Is the "event" formatter essentially unrelated to the "message" format?

Putting in the infra to make "message" work seems to touch much of the guts of godog - is that I wonder why this ticket is still open?

Thanks

(BTW long time no chat - came across some old google groups chats between us from back in 2010)

Johnlon commented 6 months ago

Likeky related to https://github.com/cucumber/godog/issues/617 as support for messages include support for attachments

Johnlon commented 1 month ago

update - I have a work in progress for this but it's been behind other fixes - more info soon .

I need this because the cuke json format is deficient when it comes to calculations of feature execution time when scenarios are running in parallel. the duration field is inadequate for this, we need start finish times