fix(examples): update api example

cucumber / godog

Cucumber for golang

MIT License

2.22k stars 250 forks source link

fix(examples): update api example #532

Closed forward32 closed 9 months ago

forward32 commented 1 year ago

🤔 What's changed?

This PR updates api example since now code inside of it doesn't match with README.

⚡️ What's your motivation?

Now you can use README to explore this example and be sure that code works properly.

🏷️ What kind of change is this?

:bank: Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

I also have updated screenshots. Need to update paths to them.

This text was originally generated from a template, then edited by hand. You can modify the template here.

codecov[bot] commented 1 year ago

Codecov Report

Merging #532 (d82c92b) into main (51d164f) will decrease coverage by 0.03%. Report is 1 commits behind head on main. The diff coverage is 77.61%.

@@            Coverage Diff             @@
##             main     #532      +/-   ##
==========================================
- Coverage   82.96%   82.94%   -0.03%     
==========================================
  Files          28       28              
  Lines        3375     3412      +37     
==========================================
+ Hits         2800     2830      +30     
- Misses        461      467       +6     
- Partials      114      115       +1

Files Changed	Coverage Δ
suite.go	`86.92% <77.61%> (-2.48%)`	:arrow_down:

... and 1 file with indirect coverage changes

aslakhellesoy commented 9 months ago

Hi @forward32,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber