cucumber / godog

Cucumber for golang
MIT License
2.22k stars 250 forks source link

docs: prefer go test to use of godog cli in README #548

Closed danielhelfand closed 1 year ago

danielhelfand commented 1 year ago

Closes #537

This pull request updates documentation to prefer go test over the godog CLI in the main README example. I realize there has been some discussion around deprecating the CLI since last checking on this, so please let me know if the deprecation information I was working off of from #478 is still accurate.

🤔 What's changed?

Remove godog CLI related details from main README example. Add notice of CLI deprecation to docs.

⚡️ What's your motivation?

If the CLI is to be deprecated or have less maintenance around it, adopters of godog should be pointed to up to date information when considering the project.

🏷️ What kind of change is this?

♻️ Anything particular you want feedback on?

📋 Checklist:


This text was originally generated from a template, then edited by hand. You can modify the template here.

codecov[bot] commented 1 year ago

Codecov Report

Merging #548 (684f65c) into main (17f07d2) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #548   +/-   ##
=======================================
  Coverage   82.24%   82.24%           
=======================================
  Files          27       27           
  Lines        3340     3340           
=======================================
  Hits         2747     2747           
  Misses        484      484           
  Partials      109      109           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

vearutop commented 1 year ago

Yes, deprecation info is still accurate, thank you for updating the docs! 👍

aslakhellesoy commented 1 year ago

Hi @danielhelfand,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber