cucumber / godog

Cucumber for golang
MIT License
2.22k stars 250 forks source link

fix invalid memory address or nil pointer dereference in RetrieveFeatures #566

Closed corneldamian closed 1 month ago

corneldamian commented 11 months ago

fix invalid memory address or nil pointer dereference when calling TestSuite RetrieveFeatures

๐Ÿท๏ธ What kind of change is this?

๐Ÿ“‹ Checklist:

hiyers commented 5 months ago

@corneldamian what are the steps to take this forward? Can I help with rebase?

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 83.30%. Comparing base (153db4e) to head (084e187). Report is 3 commits behind head on main.

Files Patch % Lines
run.go 0.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #566 +/- ## ========================================== + Coverage 83.21% 83.30% +0.09% ========================================== Files 28 28 Lines 3413 2743 -670 ========================================== - Hits 2840 2285 -555 + Misses 458 342 -116 - Partials 115 116 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aslakhellesoy commented 1 month ago

Hi @corneldamian,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! ๐Ÿพ

In return for this generous offer we hope you will:

On behalf of the Cucumber core team, Aslak Hellesรธy Creator of Cucumber