vearutop commented 6 months ago

🤔 What's changed?

This PR

Updates some of the error checks with errors.Is for better reliability with wrapping
Adds missing handling of step result statuses for ErrSkip
Adds a test to validate formatter Summary() and step execution flow

⚡️ What's your motivation?

582 introduced a fix that was invisible for current test suite (tests passing before and after), while covering the fix with a regression test it turned out, `ErrSkip` is not properly reported in `Summary()`.

🏷️ What kind of change is this?

:bug: Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct
[x] I've changed the behaviour of the code
- [x] I have added/updated tests to cover my changes.
[ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
[ ] Users should know about my change
- [ ] I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

github-actions[bot] commented 6 months ago

Go API Changes

# summary
Inferred base version: v0.13.0
Suggested version: v0.13.1

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (25274b0) 82.93% compared to head (85d342a) 83.22%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #584 +/- ## ========================================== + Coverage 82.93% 83.22% +0.28% ========================================== Files 28 28 Lines 3411 3416 +5 ========================================== + Hits 2829 2843 +14 + Misses 467 458 -9 Partials 115 115 ``` | [Files](https://app.codecov.io/gh/cucumber/godog/pull/584?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber) | Coverage Δ | | |---|---|---| | [suite.go](https://app.codecov.io/gh/cucumber/godog/pull/584?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber#diff-c3VpdGUuZ28=) | `87.09% <100.00%> (+0.17%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/cucumber/godog/pull/584/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cucumber / godog

Improve ErrSkip handling, add test for Summary and operations order #584

🤔 What's changed?

⚡️ What's your motivation?

582 introduced a fix that was invisible for current test suite (tests passing before and after), while covering the fix with a regression test it turned out, `ErrSkip` is not properly reported in `Summary()`.

🏷️ What kind of change is this?

♻️ Anything particular you want feedback on?

📋 Checklist:

Go API Changes

Codecov Report

cucumber / godog

Improve ErrSkip handling, add test for Summary and operations order #584

🤔 What's changed?

⚡️ What's your motivation?

582 introduced a fix that was invisible for current test suite (tests passing before and after), while covering the fix with a regression test it turned out, ErrSkip is not properly reported in Summary().

🏷️ What kind of change is this?

♻️ Anything particular you want feedback on?

📋 Checklist:

Go API Changes

Codecov Report

582 introduced a fix that was invisible for current test suite (tests passing before and after), while covering the fix with a regression test it turned out, `ErrSkip` is not properly reported in `Summary()`.