Fix step duration calculation

iaroslav-ciupin commented 1 month ago

🤔 What's changed?

⚡️ What's your motivation?

🏷️ What kind of change is this?

:book: Documentation (improvements without changing code)
:bank: Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
:bug: Bug fix (non-breaking change which fixes a defect)
:zap: New feature (non-breaking change which adds new behaviour)
:boom: Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct
[ ] I've changed the behaviour of the code
- [ ] I have added/updated tests to cover my changes.
[ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
[ ] Users should know about my change
- [ ] I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

vearutop commented 1 month ago

Thank you for fixing this. 👍

aslakhellesoy commented 1 month ago

Hi @iaroslav-ciupin,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber

iaroslav-ciupin commented 1 month ago

@vearutop @aslakhellesoy thank you, https://github.com/cucumber/godog/issues/615 in this issue I also asked whether we should return duration in nanoseconds or milliseconds? because cucumber-html-reporter expects milliseconds, but this library currently generates nanoseconds which leads to wrong duration in HTML report

cucumber / godog