search

cucumber / godog

Cucumber for golang
MIT License
2.32k stars 254 forks source link

Moved CHANGHELOG entry to correct location #626

Closed Johnlon closed 5 months ago

Johnlon commented 5 months ago

Moved a changelog entry to the correct location

Johnlon commented 5 months ago

@mattwynne Hi Matt - re my prev PR to add attachments - as I mentioned I accidentally merged to main (the squash and merge caught me out) - but I'm hoping that was you plan anyway. Let me know.

Please review this current PR - I'd also merge this but I don't want to offend any further than I might have already.

(BTW Matt I was previously given committer rights from changes I made to Cuke React - but I'm assuming that I should alway seek a merge by someone else such as yourself - can you confirm?)

mattwynne commented 5 months ago

@Johnlon don't worry about causing offence! 😀

We tend to favour Ship/Show/Ask as our protocol for PRs in the Cucumber org. If you have a change you know is good, like this one, don't be afraid to merge it yourself rather than getting blocked waiting for someone else to take time to review it.

Equally, if you do have an "Ask" PR and you really want feedback, feel free to make noise until you get it!