Ambiguous step detection - add support to all formatters

Johnlon commented 1 month ago

🤔 What's changed?

Previously "ambiguous" step reporting had been omitted for some of the formatters. This change adds support for "ambiguous" steps to all formatters.

⚡️ What's your motivation?

Bug fix.

🏷️ What kind of change is this?

:bug: Bug fix (non-breaking change which fixes a defect)
:zap: New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

Worth scanning the test data file changes - ie "some_scenarios_including_failing"

📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct
[x] I've changed the behaviour of the code
- [x] I have added/updated tests to cover my changes.
[ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
[ ] Users should know about my change
- [x] I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

github-actions[bot] commented 1 month ago

Go API Changes

# github.com/cucumber/godog
## compatible changes
Attach: added
Attachment: added
Attachments: added
ErrAmbiguous: added
StepAmbiguous: added

# github.com/cucumber/godog/formatters
## incompatible changes
Formatter.Ambiguous: added

# summary
Inferred base version: v0.14.1
Suggested version: v0.15.0

Johnlon commented 1 month ago

@vearutop - hi - further PR to the "ambiguous" step detection that adds full support to the formatters - as previously we only got to know about dupe steps from the test exit code.

cucumber / godog