Escape json when writing in html - Githubissues

cucumber / html-formatter

HTML formatter for reporting Cucumber results

https://cucumber.io/

MIT License

13 stars 4 forks source link

Escape json when writing in html #312

Closed mpkorstanje closed 1 month ago

mpkorstanje commented 2 months ago

🤔 What's changed?

We're writing the json messages inside a <script> element. This means that the </script> element must be escaped. Or more generally, any /.

⚡️ What's your motivation?

Fixes: #311

🏷️ What kind of change is this?

:bug: Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

Is there a better way to do this?

📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct
[x] I've changed the behaviour of the code
- [x] I have added/updated tests to cover my changes.
[x] My change requires a change to the documentation.
- [x] I have updated the documentation accordingly.
[x] Users should know about my change
- [x] I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.