cucumber / language-server

Cucumber Language Server
MIT License
35 stars 20 forks source link

bin: fix startServer import and wasm paths #30

Closed williamboman closed 2 years ago

williamboman commented 2 years ago

Description

It seems like the latest release broke the executable, where it's throwing the following exception:

/Users/williamboman/.local/share/nvim/lsp_servers/cucumber_language_server/node_modules/@cucumber/language-server/bin/cucumber-language-server.cjs:10
startServer(wasmUrls)
^
TypeError: startServer is not a function
    at Object.<anonymous> (/Users/williamboman/.local/share/nvim/lsp_servers/cucumber_language_server/node_modules/@cucumber/language-server/bin/cucumber-language-server.cjs:10:1)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:17:47

Motivation & context

It fixes the import of startServer, which is not a default export.

Type of change

Checklist:

aslakhellesoy commented 2 years ago

Thanks @williamboman!

Out of curiosity - what LSP client/editor are you using this with? I'm guessing neovim :-) How is it working for you?

williamboman commented 2 years ago

Hey @aslakhellesoy. I honestly don't really use this server myself. I've only tried it out using the neovim native LSP client. I found about this issue via tests in https://github.com/williamboman/nvim-lspconfig-test

aslakhellesoy commented 2 years ago

Oh very cool! I found it over in https://github.com/williamboman/nvim-lspconfig-test/tree/develop/tests/cucumber_language_server

Great to have someone else testing our code :-)

aslakhellesoy commented 2 years ago

Hi @williamboman,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber